[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] sockets: avoid formatting buffer
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] sockets: avoid formatting buffer that may not be NULL terminated |
|
Date: |
Wed, 5 Jul 2017 14:41:38 +0100 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Mon, Jun 26, 2017 at 11:11:59AM +0100, Daniel P. Berrange wrote:
> The 'sun_path' field in the sockaddr_un struct is not required
> to be NULL termianted, so when reporting an error, we must use
> the separate 'path' variable which is guaranteed terminated.
>
> Fixes a bug spotted by coverity that was introduced in
>
> commit ad9579aaa16d5b385922d49edac2c96c79bcfb62
> Author: Daniel P. Berrange <address@hidden>
> Date: Thu May 25 16:53:00 2017 +0100
>
> sockets: improve error reporting if UNIX socket path is too long
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> util/qemu-sockets.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature