[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.10 4/4] bsd-user/main.c: Fi
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.10 4/4] bsd-user/main.c: Fix unused variable warning |
|
Date: |
Wed, 19 Jul 2017 09:19:06 +0100 |
On 18 July 2017 at 23:01, Eric Blake <address@hidden> wrote:
> On 07/18/2017 11:26 AM, Peter Maydell wrote:
>> On OpenBSD the compiler warns:
>> bsd-user/main.c:622:21: warning: variable 'sig' set but not used
>> [-Wunused-but-set-variable]
>>
>> This is because a lot of the signal delivery code is #if-0'd
>> out as unused. Reshuffle #ifdefs a bit to silence the warning.
>
> Why not just nuke the #if 0 code instead (we can always 'git revert' it
> later as a starting point for someone that wants to implement it).
I went for the minimal change, especially given we know
that the freebsd folks have a big patchset on top of
us fixing a lot of bsd-user code and it didn't seem worth
giving them a more awkward rebase task.
thanks
-- PMM
[Qemu-trivial] [PATCH for-2.10 1/4] bsd-user/mmap.c: Move __thread attribute to right place, Peter Maydell, 2017/07/18
[Qemu-trivial] [PATCH for-2.10 3/4] bsd-user/bsdload.c: Remove write-only id_change variable, Peter Maydell, 2017/07/18
[Qemu-trivial] [PATCH for-2.10 2/4] bsd-user/elfload.c: Fix set-but-not-used warnings, Peter Maydell, 2017/07/18