Re: [Qemu-trivial] [PATCH for-2.10] Use qemu_tolower() and qemu_toupper(), not tolower() and toupper()

[Richard Henderson]

On 07/20/2017 06:31 AM, Peter Maydell wrote:
> gdbstub.c:914:13: warning: array subscript has type 'char'
>
> This reflects the fact that toupper() and tolower() give
> undefined behaviour if they are passed a value that isn't
> a valid 'unsigned char' or EOF.

Not saying we shouldn't use qemu_tolower etc, but this statement is not true at 
all.  Officially, the argument to toupper and tolower is type int.

This sounds like a bug in NetBSD -- though it may not even be that, as they may 
have done something clever and put the symbol in the middle of the data.  A 
trick that worked before compiler warnings got smarter.

Anyway, should we poison the iso name so this doesn't creep in again?

Reviewed-by: Richard Henderson <address@hidden>


r~