|
From: | Thomas Huth |
Subject: | Re: [Qemu-trivial] [Qemu-devel] [PATCH for-2.10 4/4] bsd-user/main.c: Fix unused variable warning |
Date: | Fri, 21 Jul 2017 13:18:44 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 19.07.2017 10:19, Peter Maydell wrote: > On 18 July 2017 at 23:01, Eric Blake <address@hidden> wrote: >> On 07/18/2017 11:26 AM, Peter Maydell wrote: >>> On OpenBSD the compiler warns: >>> bsd-user/main.c:622:21: warning: variable 'sig' set but not used >>> [-Wunused-but-set-variable] >>> >>> This is because a lot of the signal delivery code is #if-0'd >>> out as unused. Reshuffle #ifdefs a bit to silence the warning. >> >> Why not just nuke the #if 0 code instead (we can always 'git revert' it >> later as a starting point for someone that wants to implement it). > > I went for the minimal change, especially given we know > that the freebsd folks have a big patchset on top of > us fixing a lot of bsd-user code and it didn't seem worth > giving them a more awkward rebase task. That's fair. So FWIW: Reviewed-by: Thomas Huth <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |