[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PULL 31/31] hw/isa/pc87312: Mark the device with user_cr
From: |
Michael Tokarev |
Subject: |
[Qemu-trivial] [PULL 31/31] hw/isa/pc87312: Mark the device with user_creatable = false |
Date: |
Mon, 25 Sep 2017 00:22:49 +0300 |
From: Thomas Huth <address@hidden>
QEMU currently aborts if you try to use the device at the command
line:
$ ppc64-softmmu/qemu-system-ppc64 -S -machine prep -device pc87312
Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222:
qemu-system-ppc64: -device pc87312: Device 'parallel0' is in use
Aborted (core dumped)
It uses parallel_hds in its realize function, so I can not be
instantiated by the user again.
Signed-off-by: Thomas Huth <address@hidden>
Reviewed-by: Hervé Poussineau <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
---
hw/isa/pc87312.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/isa/pc87312.c b/hw/isa/pc87312.c
index 5ce9f0a062..48b29e3c3c 100644
--- a/hw/isa/pc87312.c
+++ b/hw/isa/pc87312.c
@@ -386,6 +386,8 @@ static void pc87312_class_init(ObjectClass *klass, void
*data)
dc->reset = pc87312_reset;
dc->vmsd = &vmstate_pc87312;
dc->props = pc87312_properties;
+ /* Reason: Uses parallel_hds[0] in realize(), so it can't be used twice */
+ dc->user_creatable = false;
}
static const TypeInfo pc87312_type_info = {
--
2.11.0
- [Qemu-trivial] [PULL 05/31] MAINTAINERS: add missing entry for vhost, (continued)
- [Qemu-trivial] [PULL 05/31] MAINTAINERS: add missing entry for vhost, Michael Tokarev, 2017/09/24
- [Qemu-trivial] [PULL 08/31] MAINTAINERS: add missing qcow2 entry, Michael Tokarev, 2017/09/24
- [Qemu-trivial] [PULL 15/31] MAINTAINERS: update docs/devel/ entries, Michael Tokarev, 2017/09/24
- [Qemu-trivial] [PULL 18/31] util/qemu-thread-posix.c: Replace OS ifdefs with CONFIG_HAVE_SEM_TIMEDWAIT, Michael Tokarev, 2017/09/24
- [Qemu-trivial] [PULL 23/31] trivial: Add missing "-m" parameter in docs/memory-hotplug.txt, Michael Tokarev, 2017/09/24
- [Qemu-trivial] [PULL 30/31] Drop gld linker usage on SunOS, Michael Tokarev, 2017/09/24
- [Qemu-trivial] [PULL 20/31] hw/display/xenfb.c: Add trace_xenfb_key_event, Michael Tokarev, 2017/09/24
- [Qemu-trivial] [PULL 22/31] chardev/baum: fix baum that releases brlapi twice, Michael Tokarev, 2017/09/24
- [Qemu-trivial] [PULL 29/31] tests/boot-sector: Increase timeout to 600 seconds, Michael Tokarev, 2017/09/24
- [Qemu-trivial] [PULL 19/31] aux-to-i2c-bridge: don't allow user to create one, Michael Tokarev, 2017/09/24
- [Qemu-trivial] [PULL 31/31] hw/isa/pc87312: Mark the device with user_creatable = false,
Michael Tokarev <=
- [Qemu-trivial] [PULL 09/31] MAINTAINERS: add missing PCI entries, Michael Tokarev, 2017/09/24
- [Qemu-trivial] [PULL 27/31] nbd-client: Use correct macro parenthesization, Michael Tokarev, 2017/09/24
- Re: [Qemu-trivial] [Qemu-devel] [PULL 00/31] Trivial patches for 2017-09-25, Peter Maydell, 2017/09/25