qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 27/32] os-posix: Drop mislead


From: Marc-André Lureau
Subject: Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 27/32] os-posix: Drop misleading comment
Date: Wed, 4 Oct 2017 14:10:36 +0200

CC qemu-trivial

On Mon, Oct 2, 2017 at 5:25 PM, Markus Armbruster <address@hidden> wrote:
> Comments explaining why we include a header tend to go bad.  This
> one's almost comical: not only doesn't qemu-options.hx use
> MAP_POPULATE anymore (since commit ef36fa1, v2.0.0, 2013), even the
> include it applies to got moved away in commit 02d0e09 (v2.7.0).
>
> Signed-off-by: Markus Armbruster <address@hidden>

Reviewed-by: Marc-André Lureau <address@hidden>


> ---
>  os-posix.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/os-posix.c b/os-posix.c
> index 92e9d85215..b9c2343b1e 100644
> --- a/os-posix.c
> +++ b/os-posix.c
> @@ -25,7 +25,6 @@
>
>  #include "qemu/osdep.h"
>  #include <sys/wait.h>
> -/*needed for MAP_POPULATE before including qemu-options.h */
>  #include <pwd.h>
>  #include <grp.h>
>  #include <libgen.h>
> --
> 2.13.6
>
>



-- 
Marc-André Lureau



reply via email to

[Prev in Thread] Current Thread [Next in Thread]