qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] linux-user: Add random ioctls


From: Marco A L Barbosa
Subject: Re: [Qemu-trivial] [PATCH] linux-user: Add random ioctls
Date: Thu, 5 Oct 2017 10:22:41 -0300

I submitted a new patch. Thanks.

On Thu, Oct 5, 2017 at 7:35 AM, Laurent Vivier <address@hidden> wrote:
On 05/10/2017 12:24, Marco A L Barbosa wrote:
>     I doesn't look really trivial...
>
>     To manage the buf field you must read buf_size and it cannot be done in
>     a generic way: you must define a function to translate the buffer, use
>     IOCTL_SPECIAL() with RNDADDENTROPY and RNDGETPOOL.
>
>     You should send your patch using "git send-email" or "git publish"
>     instead of adding it in you email client.
>
>
> Thanks for your advices.
>
> My use case only requires support for RNDGETENTCNT... Considering that
> RNDADDENTROPY and RNDGETPOOL are non trivial, would a patch with only
> RNDGETENTCNT, RNDADDTOENTCNT, RNDZAPENTCNT and RNDCLEARPOOL be accepted?

I think you can only post what you use. If it is tested, it's better...

Thanks,
Laurent



--
Marco A L Barbosa
http://malbarbo.pro.br
--

reply via email to

[Prev in Thread] Current Thread [Next in Thread]