Re: [Qemu-trivial] [PATCH 23/34] hw/dma/i8257: rename DMA_init() to i8257_dma_init()

[Eduardo Otubo\"]

On Fri, Sep 22, 2017 at 03:08:03PM -0300, Philippe Mathieu-Daudé wrote:
> On 09/22/2017 02:43 PM, Hervé Poussineau wrote:
> > Le 22/09/2017 à 18:01, Philippe Mathieu-Daudé a écrit :
> [...]
> > > +void i8257_dma_init(ISABus *bus, int high_page_enable);
> > > +
> > 
> > As you're changing the DMA_init prototype, can you add an Error **errp
> > parameter, and pass &error_abort in each caller?
> > 
> > See http://lists.gnu.org/archive/html/qemu-devel/2017-09/msg00262.html
> > for more details
> 
> If Eduardo doesn't have a patch ready I can do it.

Please go ahead.
You can also use my patch set (v2) for that as a base if you want.
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg08007.html

-- 
Eduardo Otubo
Senior Software Engineer @ RedHat