qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH 66/88] util/qemu-thread-win32: us


From: Stefan Weil
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 66/88] util/qemu-thread-win32: use g_new() family of functions
Date: Sat, 7 Oct 2017 08:47:17 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

Am 07.10.2017 um 01:50 schrieb Philippe Mathieu-Daudé:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  util/qemu-thread-win32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/util/qemu-thread-win32.c b/util/qemu-thread-win32.c
> index 94f3491a87..098fddb2af 100644
> --- a/util/qemu-thread-win32.c
> +++ b/util/qemu-thread-win32.c
> @@ -394,7 +394,7 @@ void qemu_thread_create(QemuThread *thread, const char 
> *name,
>      HANDLE hThread;
>      struct QemuThreadData *data;
>  
> -    data = g_malloc(sizeof *data);
> +    data = g_new(struct QemuThreadData, 1);
>      data->start_routine = start_routine;
>      data->arg = arg;
>      data->mode = mode;
> 

Reviewed-by: Stefan Weil <address@hidden>

Maybe you can use this simplified variant:

    QemuThreadData *data = g_new(QemuThreadData, 1);

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]