Re: [Qemu-trivial] [PATCH] linux-user: Add AT_SECURE auxval

[Michael Tokarev]

I'm Cc'ing this to qemu-devel@ for review, since this patch hasn't got any 
reviews.
Please the next time always inclure qemu-devel@ and other addresses according
to the output of scripts/get_maintainer.pl

Thanks,

/mjt

05.10.2017 17:35, Marco A L Barbosa wrote:
> This is necessary to run android ndk applications. Without this patch, the
> following error is generated:
> 
> FATAL: kernel did not supply AT_SECURE
> 
> Should AT_SECURE from host be considered or is the ids comparisons enough?
> 
> Signed-off-by: Marco A L Barbosa <address@hidden>
> ---
>  linux-user/elfload.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 79062882ba..177ce30e89 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -1354,7 +1354,7 @@ struct exec
>                                   ~(abi_ulong)(TARGET_ELF_EXEC_PAGESIZE-1))
>  #define TARGET_ELF_PAGEOFFSET(_v) ((_v) & (TARGET_ELF_EXEC_PAGESIZE-1))
>  
> -#define DLINFO_ITEMS 14
> +#define DLINFO_ITEMS 15
>  
>  static inline void memcpy_fromfs(void * to, const void * from, unsigned long 
> n)
>  {
> @@ -1782,6 +1782,7 @@ static abi_ulong create_elf_tables(abi_ulong p, int 
> argc, int envc,
>      NEW_AUX_ENT(AT_HWCAP, (abi_ulong) ELF_HWCAP);
>      NEW_AUX_ENT(AT_CLKTCK, (abi_ulong) sysconf(_SC_CLK_TCK));
>      NEW_AUX_ENT(AT_RANDOM, (abi_ulong) u_rand_bytes);
> +    NEW_AUX_ENT(AT_SECURE, (abi_ulong) (getuid() != geteuid() || getgid() != 
> getegid()));
>  
>  #ifdef ELF_HWCAP2
>      NEW_AUX_ENT(AT_HWCAP2, (abi_ulong) ELF_HWCAP2);
>