[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] gtk: fix wrong id between textur
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer |
Date: |
Wed, 8 Nov 2017 09:49:26 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
Hi Anthoine,
Cc'ing Gerd Hoffmann who is the maintainer of this file.
See
https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer:
$ ./scripts/get_maintainer.pl -f ui/gtk-gl-area.c
Gerd Hoffmann <address@hidden> (odd fixer:Graphics)
On 10/02/2017 09:40 AM, Anthoine Bourgeois wrote:
> From: Anthoine Bourgeois <address@hidden>
>
> The gd_gl_area_scanout_texture must destroy framebuffer if there is
> no texture id instead of no framebuffer id.
> The effect was a black screen with "-vga virtio -display gtk,gl=on"
> options.
> The bug was introduce by a4f113fd "gtk: use framebuffer helper functions."
>
> Signed-off-by: Anthoine Bourgeois <address@hidden>
> ---
> ui/gtk-gl-area.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c
> index 18b298f..026b7d7 100644
> --- a/ui/gtk-gl-area.c
> +++ b/ui/gtk-gl-area.c
> @@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener
> *dcl,
>
> gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area));
>
> - if (vc->gfx.guest_fb.framebuffer == 0 ||
> - vc->gfx.w == 0 || vc->gfx.h == 0) {
> + if (backing_id == 0 || vc->gfx.w == 0 || vc->gfx.h == 0) {
> gtk_gl_area_set_scanout_mode(vc, false);
> return;
> }
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-trivial] [Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer,
Philippe Mathieu-Daudé <=