[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] coroutine: Fix documentation of co_aio_sleep_
Re: [Qemu-trivial] [PATCH] coroutine: Fix documentation of co_aio_sleep_ns()
Wed, 8 Nov 2017 15:42:26 +0000
On Tue, Nov 07, 2017 at 04:37:08PM -0600, Eric Blake wrote:
> co_sleep_ns() was removed in commit 0b9caf9b, leaving behind a
> stale comment. Update the documentation to match the current
> usage of this function.
> Suggested-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
> include/qemu/coroutine.h | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
> diff --git a/include/qemu/coroutine.h b/include/qemu/coroutine.h
> index 9aff9a735e..01ae415767 100644
> --- a/include/qemu/coroutine.h
> +++ b/include/qemu/coroutine.h
> @@ -262,8 +262,11 @@ void qemu_co_rwlock_unlock(CoRwlock *lock);
> * Yield the coroutine for a given duration
> - * Behaves similarly to co_sleep_ns(), but the sleeping coroutine will be
> - * resumed when using aio_poll().
> + * This function uses timers and hence needs to know the event loop
> + * (#AioContext) to place the timer on. In any case, co_aio_sleep_ns()
> + * does not affect the #AioContext where the current coroutine is running,
> + * as the coroutine will restart on the same #AioContext that it is
> + * running on.
I cannot parse the second sentence. What does "affecting" an AioContext
mean? Does "where the current coroutine is running" simply mean "the
What is it trying to say? My guess is: the caller will be resumed in
the current AioContext, not the timer's AioContext.
Description: PGP signature