Re: [Qemu-trivial] [PATCH qemu v2] machine: Polish -machine xxx, help

[Alexey Kardashevskiy]

On 29/01/18 16:03, Alexey Kardashevskiy wrote:
> On 15/12/17 15:47, Alexey Kardashevskiy wrote:
>> On 26/10/17 12:41, Alexey Kardashevskiy wrote:
>>> The "-machine xxx,help" prints kernel-irqchip possible values as
>>> "OnOffSplit", this adds separators to the printed line.
>>>
>>> Also, since only lower case letters are specified in qapi/common.json,
>>> this changes the letter cases too.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>>
>> ping?
> 
> 
> anyone?

Let's try trivial list now :)


> 
>>
>>
>>> ---
>>>
>>> address@hidden:~$ ./qemu-system-ppc64 -machine pseries,help 2>&1 | grep 
>>> kernel-irqchip
>>>
>>> Was:
>>> pseries-2.11.kernel-irqchip=OnOffSplit (Configure KVM in-kernel irqchip)
>>>
>>> Now:
>>> pseries-2.11.kernel-irqchip=on|off|split (Configure KVM in-kernel irqchip)
>>> ---
>>>  hw/core/machine.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/hw/core/machine.c b/hw/core/machine.c
>>> index 36c2fb069c..bd3db14e12 100644
>>> --- a/hw/core/machine.c
>>> +++ b/hw/core/machine.c
>>> @@ -506,7 +506,7 @@ static void machine_class_init(ObjectClass *oc, void 
>>> *data)
>>>      object_class_property_set_description(oc, "accel",
>>>          "Accelerator list", &error_abort);
>>>  
>>> -    object_class_property_add(oc, "kernel-irqchip", "OnOffSplit",
>>> +    object_class_property_add(oc, "kernel-irqchip", "on|off|split",
>>>          NULL, machine_set_kernel_irqchip,
>>>          NULL, NULL, &error_abort);
>>>      object_class_property_set_description(oc, "kernel-irqchip",
>>>
>>
>>
> 
> 


-- 
Alexey