qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] [PATCH] configure: Add missing space when using --with-pk


From: Thomas Huth
Subject: [Qemu-trivial] [PATCH] configure: Add missing space when using --with-pkgversion
Date: Wed, 14 Feb 2018 18:31:45 +0100

When running configure with --with-pkgversion=foo there is no
space anymore between the version number and the parentheses:

$ m68k-softmmu/qemu-system-m68k -version
QEMU emulator version 2.11.50(foo)

Fix it by moving the space from the configure script to the Makefile.

Fixes: 67a1de0d195a6185c39b436159c9ffc7720bf979
Buglink: https://bugs.launchpad.net/qemu/+bug/1673373
Signed-off-by: Thomas Huth <address@hidden>
---
 Makefile  | 2 +-
 configure | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 4ec7a3c..41adbc9 100644
--- a/Makefile
+++ b/Makefile
@@ -369,7 +369,7 @@ qemu-version.h: FORCE
                (cd $(SRC_PATH); \
                printf '#define QEMU_PKGVERSION '; \
                if test -n "$(PKGVERSION)"; then \
-                       printf '"$(PKGVERSION)"\n'; \
+                       printf '" ($(PKGVERSION))"\n'; \
                else \
                        if test -d .git; then \
                                printf '" ('; \
diff --git a/configure b/configure
index fe9eea9..1fc687c 100755
--- a/configure
+++ b/configure
@@ -1162,7 +1162,7 @@ for opt do
   ;;
   --disable-blobs) blobs="no"
   ;;
-  --with-pkgversion=*) pkgversion=" ($optarg)"
+  --with-pkgversion=*) pkgversion="$optarg"
   ;;
   --with-coroutine=*) coroutine="$optarg"
   ;;
-- 
1.8.3.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]