[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2 08/30] hw/i386: use the BYTE-based definiti
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-trivial] [PATCH v2 08/30] hw/i386: use the BYTE-based definitions |
Date: |
Mon, 5 Mar 2018 18:51:49 +0000 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Mon, Mar 05, 2018 at 08:27:10AM -0300, Philippe Mathieu-Daudé wrote:
> It eases code review, unit is explicit.
>
> Patch generated using:
>
> $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
>
> and modified manually.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/i386/xen/xen-mapcache.c | 2 +-
>
> diff --git a/hw/i386/xen/xen-mapcache.c b/hw/i386/xen/xen-mapcache.c
> index efa35dc6e0..5f48fde799 100644
> --- a/hw/i386/xen/xen-mapcache.c
> +++ b/hw/i386/xen/xen-mapcache.c
> @@ -47,7 +47,7 @@
> * From empirical tests I observed that qemu use 75MB more than the
> * max_mcache_size.
> */
> -#define NON_MCACHE_MEMORY_SIZE (80 * 1024 * 1024)
> +#define NON_MCACHE_MEMORY_SIZE (80 * M_BYTE)
>
> typedef struct MapCacheEntry {
> hwaddr paddr_index;
Acked-by: Anthony PERARD <address@hidden>
--
Anthony PERARD
- [Qemu-trivial] [PATCH v2 03/30] hw/block/nvme: include the "qemu/cutils.h" in the source file, (continued)
- [Qemu-trivial] [PATCH v2 03/30] hw/block/nvme: include the "qemu/cutils.h" in the source file, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [RFC PATCH v2 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h", Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 04/30] hw/lm32/milkymist: remove unused include, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 05/30] hw/mips/r4k: constify params_size, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 06/30] hw/mips: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 07/30] hw/arm: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 08/30] hw/i386: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 09/30] hw/sparc: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 10/30] hw/ppc: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 11/30] hw/s390x: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 13/30] hw/xtensa: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 12/30] hw/hppa: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 15/30] hw/lm32: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 17/30] hw/tricore: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 14/30] hw/alpha: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05
- [Qemu-trivial] [PATCH v2 16/30] hw/sh4: use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/03/05