qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH 0/3] hw/rdma: Fix 32-bit compilat


From: no-reply
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 0/3] hw/rdma: Fix 32-bit compilation
Date: Wed, 21 Mar 2018 22:07:35 -0700 (PDT)

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/3] hw/rdma: Fix 32-bit compilation

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7968402545 hw/rdma: Fix 32-bit compilation
3924e0635d hw/rdma: Use correct print format in CHK_ATTR macro
928edb0554 hw/rdma: Change host_virt to void *

=== OUTPUT BEGIN ===
Checking PATCH 1/3: hw/rdma: Change host_virt to void *...
Checking PATCH 2/3: hw/rdma: Use correct print format in CHK_ATTR macro...
Checking PATCH 3/3: hw/rdma: Fix 32-bit compilation...
WARNING: line over 80 characters
#40: FILE: hw/rdma/rdma_backend.c:180:
+            pr_dbg("ibv_create_ah failed for gid <0x%" PRIx64 ", 0x%" PRIx64 
">\n",

ERROR: space prohibited before that close parenthesis ')'
#78: FILE: hw/rdma/rdma_backend.c:673:
+    CHK_ATTR(dev_attr, backend_dev->dev_attr, max_mr_size, "%" PRId64 );

WARNING: line over 80 characters
#244: FILE: hw/rdma/vmw/pvrdma_main.c:345:
+        pr_err("Error trying to set REG value, addr=0x%" PRIx64 ", val=0x%" 
PRIx64 "\n",

total: 1 errors, 2 warnings, 248 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden

reply via email to

[Prev in Thread] Current Thread [Next in Thread]