[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v3 41/41] cutils: Do not include "qemu/units.h
From: |
Marcel Apfelbaum |
Subject: |
Re: [Qemu-trivial] [PATCH v3 41/41] cutils: Do not include "qemu/units.h" directly |
Date: |
Mon, 16 Apr 2018 12:53:16 +0300 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 16/04/2018 2:43, Philippe Mathieu-Daudé wrote:
> All files using "qemu/units.h" definitions already include it directly,
> we can now remove it from "qemu/cutils.h".
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> include/qemu/cutils.h | 1 -
> hw/core/machine.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/qemu/cutils.h b/include/qemu/cutils.h
> index 056e6629bb..cdb0f0db75 100644
> --- a/include/qemu/cutils.h
> +++ b/include/qemu/cutils.h
> @@ -2,7 +2,6 @@
> #define QEMU_CUTILS_H
>
> #include "qemu/fprintf-fn.h"
> -#include "qemu/units.h"
>
> /**
> * pstrcpy:
> diff --git a/hw/core/machine.c b/hw/core/machine.c
> index 2040177664..8f70c5ad94 100644
> --- a/hw/core/machine.c
> +++ b/hw/core/machine.c
> @@ -19,7 +19,7 @@
> #include "sysemu/sysemu.h"
> #include "sysemu/numa.h"
> #include "qemu/error-report.h"
> -#include "qemu/cutils.h"
> +#include "qemu/units.h"
> #include "sysemu/qtest.h"
>
> static char *machine_get_accel(Object *obj, Error **errp)
>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Thanks,
Marcel
- Re: [Qemu-trivial] [PATCH v3 34/41] hw/usb: Use the BYTE-based definitions, (continued)
- [Qemu-trivial] [PATCH v3 35/41] hw/sd: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 36/41] hw/vfio: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 37/41] hw/virtio: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 38/41] hw/rdma: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 39/41] hw/nvdimm: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 40/41] hw/loader: Use the BYTE-based definitions, Philippe Mathieu-Daudé, 2018/04/15
- [Qemu-trivial] [PATCH v3 41/41] cutils: Do not include "qemu/units.h" directly, Philippe Mathieu-Daudé, 2018/04/15
- Re: [Qemu-trivial] [PATCH v3 41/41] cutils: Do not include "qemu/units.h" directly,
Marcel Apfelbaum <=
- Message not available
- Message not available