Re: [Qemu-trivial] [Qemu-devel] [PATCH v1] configure: require glib-2.24

[Daniel P . Berrangé]

On Wed, Apr 18, 2018 at 02:38:37PM +0200, Olaf Hering wrote:
> Since usage of g_realloc_n was introduced, glib-2.22 can not be used anymore.
> Fixes commit 418026ca43 ("util: Introduce vfio helpers")

Normally we expect ./include/glib-compat.h to be changed in this scenario
to add compat for the missing symbol.

IIRC, one of Peters desired build targets required 2.22, but I guess we
missed this bug because that platform would not enable vfio functionality ?



> 
> Signed-off-by: Olaf Hering <address@hidden>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 6e9b994f21..81760ef45a 100755
> --- a/configure
> +++ b/configure
> @@ -3369,7 +3369,7 @@ fi
>  if test "$mingw32" = yes; then
>      glib_req_ver=2.30
>  else
> -    glib_req_ver=2.22
> +    glib_req_ver=2.24
>  fi



>  glib_modules=gthread-2.0
>  if test "$modules" = yes; then
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|