[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v2] configure: require glib-2.24 on Linux
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-trivial] [PATCH v2] configure: require glib-2.24 on Linux |
Date: |
Wed, 18 Apr 2018 17:42:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 18/04/2018 16:54, Olaf Hering wrote:
> Since usage of g_realloc_n was introduced, glib-2.22 can not be used
> anymore on Linux. Leave non-Linux unchanged because one developer system
> still uses it.
> Fixes commit 418026ca43 ("util: Introduce vfio helpers")
>
> Signed-off-by: Olaf Hering <address@hidden>
> ---
> configure | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 6e9b994f21..ca19a66726 100755
> --- a/configure
> +++ b/configure
> @@ -3369,7 +3369,11 @@ fi
> if test "$mingw32" = yes; then
> glib_req_ver=2.30
> else
> - glib_req_ver=2.22
> + if test "$targetos" = Linux; then
> + glib_req_ver=2.24
> + else
> + glib_req_ver=2.22
> + fi
> fi
> glib_modules=gthread-2.0
> if test "$modules" = yes; then
>
I think for 2.12 it's okay to just document this. For 2.13 we should
raise the bar uniformly (and anyway remove g_realloc_n in favor of g_renew).
Paolo