[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v1] configure: recognize more rpm
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v1] configure: recognize more rpmbuild macros |
|
Date: |
Wed, 9 May 2018 12:32:13 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 09/05/2018 07:44, Olaf Hering wrote:
> Am Wed, 9 May 2018 00:15:42 +0200
> schrieb Paolo Bonzini <address@hidden>:
>
>> Actually, --program-prefix= and --exec-prefix= have a meaning, they
>> cannot just be ignored. For now I've removed this line; what is the
>> exact incantation used by SUSE Linux?
>
> Like in every other rpm.rpm I guess:
>
> /usr/lib/rpm/macros:%_exec_prefix %{_prefix}
> /usr/lib/rpm/macros: --program-prefix=%{?_program_prefix} \\\
> /usr/lib/rpm/macros: --exec-prefix=%{_exec_prefix} \\\
>
> Are you saying your %configure is different from my %configure?
> In any case, qemu has to tolerate both options.
I agree that it's a worthwhile improvement but it also has to fail if
use an argument other than the default (or implement them, which I'm
probably not advising here). Otherwise packaging breaks if someone for
whatever reason overrides the %_program_prefix and %_exec_prefix macros.
Paolo
signature.asc
Description: OpenPGP digital signature