[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] tcg: remove softfloat from --dis
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] tcg: remove softfloat from --disable-tcg builds |
|
Date: |
Tue, 22 May 2018 13:53:45 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/22/2018 12:20 PM, Paolo Bonzini wrote:
> Even though the presence of softfloat does not cause --disable-tcg builds to
> fail,
> it is the single largest .o file in them. Remove it, since TCG is the only
> client.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> Makefile.target | 2 +-
> hw/i386/x86-iommu-stub.c | 132 +++++++++++++++++++++++++++++++++++++++
Assuming this wasn't supposed to be here.
> 2 files changed, 133 insertions(+), 1 deletion(-)
> create mode 100644 hw/i386/x86-iommu-stub.c
>
> diff --git a/Makefile.target b/Makefile.target
> index d0ec77a307..dad2cf8778 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -97,7 +97,7 @@ obj-$(CONFIG_TCG) += tcg/tcg.o tcg/tcg-op.o
> tcg/tcg-op-vec.o tcg/tcg-op-gvec.o
> obj-$(CONFIG_TCG) += tcg/tcg-common.o tcg/optimize.o
> obj-$(CONFIG_TCG_INTERPRETER) += tcg/tci.o
> obj-$(CONFIG_TCG_INTERPRETER) += disas/tci.o
> -obj-y += fpu/softfloat.o
> +obj-$(CONFIG_TCG) += fpu/softfloat.o
But for this change alone,
Acked-by: Richard Henderson <address@hidden>
r~