[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v4 15/21] hw/block/nvme: Include "qemu/cutils.
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-trivial] [PATCH v4 15/21] hw/block/nvme: Include "qemu/cutils.h" directly in the source file |
Date: |
Mon, 28 May 2018 21:42:05 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 05/28/2018 08:27 PM, Philippe Mathieu-Daudé wrote:
I forgot to add this commit description:
"block/nvme.h" does not require any declaration of "qemu/cutils.h".
Simplify dependencies by directly include it in the source file
where the declarations are used.
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Reviewed-by: Thomas Huth <address@hidden>
> ---
> hw/block/nvme.h | 1 -
> hw/block/nvme.c | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/block/nvme.h b/hw/block/nvme.h
> index 8f3981121d..cabcf20c32 100644
> --- a/hw/block/nvme.h
> +++ b/hw/block/nvme.h
> @@ -1,6 +1,5 @@
> #ifndef HW_NVME_H
> #define HW_NVME_H
> -#include "qemu/cutils.h"
> #include "block/nvme.h"
>
> typedef struct NvmeAsyncEvent {
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 85d2406400..811084b6a7 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -35,6 +35,7 @@
> #include "sysemu/block-backend.h"
>
> #include "qemu/log.h"
> +#include "qemu/cutils.h"
> #include "trace.h"
> #include "nvme.h"
>
>
Re: [Qemu-trivial] [PATCH v4 09/21] target: Do not include "exec/exec-all.h" if it is not necessary, Cornelia Huck, 2018/05/30
[Qemu-trivial] [PATCH v4 11/21] hw: Do not include "exec/address-spaces.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 13/21] hw: Do not include "sysemu/blockdev.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 14/21] hw: Do not include "sysemu/blockdev.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 15/21] hw/block/nvme: Include "qemu/cutils.h" directly in the source file, Philippe Mathieu-Daudé, 2018/05/28
- Re: [Qemu-trivial] [PATCH v4 15/21] hw/block/nvme: Include "qemu/cutils.h" directly in the source file,
Philippe Mathieu-Daudé <=
[Qemu-trivial] [PATCH v4 16/21] hw/misc/mips_itu: Cleanup includes, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 17/21] hw/misc/sga: Use the correct ISA include, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 18/21] hw/hppa: Remove unused include, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 20/21] hw/ide: Remove unused include, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 19/21] hw/i386/pc: Remove unused include, Philippe Mathieu-Daudé, 2018/05/28