[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-trivial] [PATCH v4 01/21] vfio: Include "exec/address-spaces.h" directly in the source file |
Date: |
Tue, 29 May 2018 12:45:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 29/05/2018 11:53, Cornelia Huck wrote:
> On Mon, 28 May 2018 21:36:31 -0300
> Philippe Mathieu-Daudé <address@hidden> wrote:
>
>> On 05/28/2018 09:06 PM, Michael S. Tsirkin wrote:
>>> On Mon, May 28, 2018 at 05:48:05PM -0600, Alex Williamson wrote:
>>>> On Mon, 28 May 2018 20:26:59 -0300
>>>> Philippe Mathieu-Daudé <address@hidden> wrote:
>>>>
>>>> -ENOCOMMITLOG
>>
>> Oops sorry Alex, I meant to add some, but missed this while rebasing.
>>
>>>> Why? Tangible benefit. Looks like noise. Thanks,
>>>>
>>> I agree it should have a commit log, but .c files
>>> should be self-sufficient not rely on .h files
>>> pulling in headers for symbols the .h does not use
>>> itself.
>>
>> I meant:
>>
>> No declaration of "hw/vfio/vfio-common.h" directly requires to include
>> the "exec/address-spaces.h" header. To simplify dependencies and
>> ease following cleanup of "exec/address-spaces.h", directly include
>> it in the source file where the declaration are used.
>>
>>> This is better because it makes refactoring easier.
>>>
>>>>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>>>>> ---
>>>>> include/hw/vfio/vfio-common.h | 1 -
>>>>> hw/vfio/ccw.c | 1 +
>>>>> hw/vfio/platform.c | 1 +
>>>>> 3 files changed, 2 insertions(+), 1 deletion(-)
>
> With the description added:
>
> Acked-by: Cornelia Huck <address@hidden>
>
Alex, is the description okay with you too?
Thanks,
Paolo
[Qemu-trivial] [PATCH v4 02/21] accel: Do not include "exec/address-spaces.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 03/21] target: Do not include "exec/address-spaces.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 04/21] memory: Do not include "exec/ioport.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 05/21] target/i386: Do not include "exec/ioport.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 06/21] target/xtensa: Include "qemu/timer.h" to use NANOSECONDS_PER_SECOND, Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 07/21] target/ppc: Include "exec/exec-all.h" which provides tlb_flush(), Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 08/21] target/hppa: Include "qemu/log.h" to use qemu_log(), Philippe Mathieu-Daudé, 2018/05/28
[Qemu-trivial] [PATCH v4 10/21] hw: Do not include "exec/ioport.h" if it is not necessary, Philippe Mathieu-Daudé, 2018/05/28