[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 33/40] hw/i386: Use the IEC bi
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v4 33/40] hw/i386: Use the IEC binary prefix definitions |
|
Date: |
Sun, 10 Jun 2018 23:29:27 -0300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06/10/2018 11:18 PM, Michael S. Tsirkin wrote:
> On Sun, Jun 10, 2018 at 10:14:54PM -0300, Philippe Mathieu-Daudé wrote:
>> @@ -1392,11 +1393,11 @@ void pc_memory_init(PCMachineState *pcms,
>> }
>>
>> machine->device_memory->base =
>> - ROUND_UP(0x100000000ULL + pcms->above_4g_mem_size, 1ULL << 30);
>> + ROUND_UP(0x100000000ULL + pcms->above_4g_mem_size, GiB);
>>
>
>
> For some reason, GiB got special treatment. Why not 1* GiB?
Oops I didn't notice, I really prefer "1 * GiB" too.
- Re: [Qemu-trivial] [Qemu-devel] [Qemu-ppc] [PATCH v4 32/40] hw/ppc: Use the IEC binary prefix definitions, (continued)
- [Qemu-trivial] [PATCH v4 34/40] hw/net: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-trivial] [PATCH v4 35/40] hw/usb: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-trivial] [PATCH v4 36/40] hw/sd: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-trivial] [PATCH v4 37/40] hw/vfio: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-trivial] [PATCH v4 38/40] hw/virtio: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-trivial] [PATCH v4 39/40] hw/rdma: Use the IEC binary prefix definitions, Philippe Mathieu-Daudé, 2018/06/10
- [Qemu-trivial] [PATCH v4 40/40] cutils: Do not include "qemu/units.h" directly, Philippe Mathieu-Daudé, 2018/06/10
- Message not available
- Re: [Qemu-trivial] [PATCH v4 00/40] Use the IEC binary prefix definitions, Michael S. Tsirkin, 2018/06/11
- Re: [Qemu-trivial] [PATCH v4 00/40] Use the IEC binary prefix definitions, Eric Blake, 2018/06/11
- Re: [Qemu-trivial] [PATCH v4 00/40] Use the IEC binary prefix definitions, Cornelia Huck, 2018/06/11