Re: [Qemu-trivial] [Qemu-devel] [PATCH] vl.c: Don't zero-initialize statics for serial_hds

[Peter Maydell]

Ping^2 for qemu-trivial?

thanks
-- PMM

On 29 May 2018 at 16:25, Peter Maydell <address@hidden> wrote:
> Ping for application via qemu-trivial?
>
> thanks
> -- PMM
>
> On 26 April 2018 at 15:19, Thomas Huth <address@hidden> wrote:
>> On 26.04.2018 16:02, Peter Maydell wrote:
>>> checkpatch reminds us that statics shouldn't be zero-initialized:
>>>
>>> ERROR: do not initialise statics to 0 or NULL
>>> #35: FILE: vl.c:157:
>>> +static int num_serial_hds = 0;
>>>
>>> ERROR: do not initialise statics to 0 or NULL
>>> #36: FILE: vl.c:158:
>>> +static Chardev **serial_hds = NULL;
>>>
>>> I forgot to fix this in 6af2692e86f9fdfb3d; do so now.
>>>
>>> Signed-off-by: Peter Maydell <address@hidden>
>>> ---
>>> I wouldn't bother with this except that I forgot to fold
>>> it in when applying the serial-limits patchset.
>>>
>>>  vl.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/vl.c b/vl.c
>>> index 616956adf1..6d8b869dad 100644
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -154,8 +154,8 @@ QEMUClockType rtc_clock;
>>>  int vga_interface_type = VGA_NONE;
>>>  static DisplayOptions dpy;
>>>  int no_frame;
>>> -static int num_serial_hds = 0;
>>> -static Chardev **serial_hds = NULL;
>>> +static int num_serial_hds;
>>> +static Chardev **serial_hds;
>>>  Chardev *parallel_hds[MAX_PARALLEL_PORTS];
>>>  Chardev *virtcon_hds[MAX_VIRTIO_CONSOLES];
>>>  Chardev *sclp_hds[MAX_SCLP_CONSOLES];
>>>
>>
>> Reviewed-by: Thomas Huth <address@hidden>