Re: [Qemu-trivial] [Qemu-devel] [PATCH] trivial: Make bios files and source files non-executable

[David Hildenbrand]

On 13.06.2018 07:24, Thomas Huth wrote:
> These files can not be executed on the host, so they should not be
> marked as executable.

Or can not be executed at all :)

Reviewed-by: David Hildenbrand <address@hidden>

> 
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  block/blkreplay.c                  |   0
>  pc-bios/hppa-firmware.img          | Bin
>  pc-bios/palcode-clipper            | Bin
>  pc-bios/u-boot-sam460-20100605.bin | Bin
>  pc-bios/u-boot.e500                | Bin
>  replay/replay-char.c               |   0
>  6 files changed, 0 insertions(+), 0 deletions(-)
>  mode change 100755 => 100644 block/blkreplay.c
>  mode change 100755 => 100644 pc-bios/hppa-firmware.img
>  mode change 100755 => 100644 pc-bios/palcode-clipper
>  mode change 100755 => 100644 pc-bios/u-boot-sam460-20100605.bin
>  mode change 100755 => 100644 pc-bios/u-boot.e500
>  mode change 100755 => 100644 replay/replay-char.c
> 
> diff --git a/block/blkreplay.c b/block/blkreplay.c
> old mode 100755
> new mode 100644
> diff --git a/pc-bios/hppa-firmware.img b/pc-bios/hppa-firmware.img
> old mode 100755
> new mode 100644
> diff --git a/pc-bios/palcode-clipper b/pc-bios/palcode-clipper
> old mode 100755
> new mode 100644
> diff --git a/pc-bios/u-boot-sam460-20100605.bin 
> b/pc-bios/u-boot-sam460-20100605.bin
> old mode 100755
> new mode 100644
> diff --git a/pc-bios/u-boot.e500 b/pc-bios/u-boot.e500
> old mode 100755
> new mode 100644
> diff --git a/replay/replay-char.c b/replay/replay-char.c
> old mode 100755
> new mode 100644
> 


-- 

Thanks,

David / dhildenb