[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-trivial] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore |
Date: |
Wed, 13 Jun 2018 14:38:40 +0100 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Wed, Jun 13, 2018 at 07:05:21AM +0200, Thomas Huth wrote:
> We've got three ways of enabling an accelerator: -machine accel=xyz,
> -accel xyz and -enable-xyz. For new QEMU users, this must be very
> confusing ("Which one do I have to use? Is there a difference between
> the options?"). While -enable-kvm was useful in the past, there is no
> real good reason for using it anymore today ("-accel kvm" is even less
> to type than "-enable-kvm"), so let's decrease the confusing amount of
> options in our documenation a little bit by removing the -enable-xyz
> here. Note that the option itself is neither removed nor marked as
> deprecated - since -enable-kvm is likely used in a lot of scripts and
> since its code is easy to maintain, we should keep it around to avoid
> to break old setups.
>
> Signed-off-by: Thomas Huth <address@hidden>
> ---
> PS: I guess Paolo won't like this patch ... let's try it anyway ;-)
It's widely used and we're removing the documentation for it?! That is
likely to cause issues for new users who refer to the man page to
understand the QEMU command-lines they see online, in scripts, etc.
IMO -enable-kvm is not worth inconveniencing users about. We gain very
little from abolishing it from docs and/or code, but its absence will
annoy our users.
signature.asc
Description: PGP signature
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/4] Replace '-machine accel=xyz' with '-accel xyz', (continued)
- [Qemu-trivial] [PATCH 2/4] Replace '-enable-kvm' with '-accel kvm' in docs and help texts, Thomas Huth, 2018/06/13
- [Qemu-trivial] [PATCH 3/4] qemu-options: Improve the documentation of '-accel' and '-machine accel=...', Thomas Huth, 2018/06/13
- [Qemu-trivial] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore, Thomas Huth, 2018/06/13
- Re: [Qemu-trivial] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore, Paolo Bonzini, 2018/06/13
- Re: [Qemu-trivial] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore,
Stefan Hajnoczi <=
- Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore, Daniel P . Berrangé, 2018/06/13
- Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore, Thomas Huth, 2018/06/13
- Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore, Daniel P . Berrangé, 2018/06/13
- Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore, Thomas Huth, 2018/06/13
- Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore, Markus Armbruster, 2018/06/13
- Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore, Cornelia Huck, 2018/06/19
- Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore, Paolo Bonzini, 2018/06/19
- Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore, Eduardo Habkost, 2018/06/22
- Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore, Thomas Huth, 2018/06/22
- Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH 4/4] qemu-options: Do not show -enable-kvm and -enable-hax in the docs anymore, Eduardo Habkost, 2018/06/22