[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 05/11] hw/display/cirrus: Convert printf() cal
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-trivial] [PATCH 05/11] hw/display/cirrus: Convert printf() calls to trace events |
Date: |
Fri, 22 Jun 2018 08:22:25 +0200 |
User-agent: |
NeoMutt/20180512 |
On Thu, Jun 21, 2018 at 02:12:51PM -0300, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/display/cirrus_vga.c | 25 ++++++-------------------
> hw/display/trace-events | 2 ++
> 2 files changed, 8 insertions(+), 19 deletions(-)
>
> diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c
> index 138ae961b9..a826bef6ec 100644
> --- a/hw/display/cirrus_vga.c
> +++ b/hw/display/cirrus_vga.c
> @@ -2608,11 +2608,8 @@ static uint64_t cirrus_vga_ioport_read(void *opaque,
> hwaddr addr,
> break;
> case 0x3c5:
> val = cirrus_vga_read_sr(c);
> + trace_vga_cirrus_read_reg("SR", s->sr_index, val);
> break;
> -#ifdef DEBUG_VGA_REG
> - printf("vga: read SR%x = 0x%02x\n", s->sr_index, val);
> -#endif
Indention looks weird.
otherwise the patch looks fine.
cheers,
Gerd
- [Qemu-trivial] [PATCH 04/11] hw/char/parallel: Convert from pdebug() macro to trace events, (continued)
- [Qemu-trivial] [PATCH 04/11] hw/char/parallel: Convert from pdebug() macro to trace events, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-trivial] [PATCH 06/11] hw/input/tsc2005: Convert a fprintf() call to trace events, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-trivial] [PATCH 07/11] hw/net/ne2000: Add trace events, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-trivial] [PATCH 08/11] hw/net/ne2000: Convert printf() calls to trace events, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-trivial] [PATCH 09/11] hw/net/etraxfs_eth: Convert printf() calls to trace events, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-trivial] [PATCH 10/11] hw/block/fdc: Convert from FLOPPY_DPRINTF() macro to trace events, Philippe Mathieu-Daudé, 2018/06/21
- [Qemu-trivial] [PATCH 11/11] hw/block/pflash_cfi: Convert from DPRINTF() macro to trace events, Philippe Mathieu-Daudé, 2018/06/21
- Message not available
- Re: [Qemu-trivial] [PATCH 05/11] hw/display/cirrus: Convert printf() calls to trace events,
Gerd Hoffmann <=
Re: [Qemu-trivial] [Qemu-devel] [PATCH 00/11] hw: various conversions to trace-events, Stefan Hajnoczi, 2018/06/28