[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH v3 01/16] hw/input/pckbd: Use qemu_log_mask(GU
From: |
Thomas Huth |
Subject: |
Re: [Qemu-trivial] [PATCH v3 01/16] hw/input/pckbd: Use qemu_log_mask(GUEST_ERROR) instead of fprintf |
Date: |
Mon, 25 Jun 2018 13:55:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 24.06.2018 06:05, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/input/pckbd.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/input/pckbd.c b/hw/input/pckbd.c
> index f33e3fc63d..07c8801387 100644
> --- a/hw/input/pckbd.c
> +++ b/hw/input/pckbd.c
> @@ -22,6 +22,7 @@
> * THE SOFTWARE.
> */
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "hw/hw.h"
> #include "hw/isa/isa.h"
> #include "hw/i386/pc.h"
> @@ -308,7 +309,8 @@ static void kbd_write_command(void *opaque, hwaddr addr,
> /* ignore that */
> break;
> default:
> - fprintf(stderr, "qemu: unsupported keyboard cmd=0x%02x\n", (int)val);
> + qemu_log_mask(LOG_GUEST_ERROR,
> + "unsupported keyboard cmd=0x%02" PRIx64 "\n", val);
> break;
> }
> }
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-trivial] [PATCH v3 00/16] hw/arm: use qemu_log_mask instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-trivial] [PATCH v3 01/16] hw/input/pckbd: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- Re: [Qemu-trivial] [PATCH v3 01/16] hw/input/pckbd: Use qemu_log_mask(GUEST_ERROR) instead of fprintf,
Thomas Huth <=
- [Qemu-trivial] [PATCH v3 02/16] hw/input/tsc2005: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-trivial] [PATCH v3 03/16] hw/dma/omap_dma: Use qemu_log_mask(UNIMP) instead of printf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-trivial] [PATCH v3 05/16] hw/ssi/omap_spi: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-trivial] [PATCH v3 04/16] hw/dma/omap_dma: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-trivial] [PATCH v3 06/16] hw/sd/omap_mmc: Use qemu_log_mask(UNIMP) instead of printf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-trivial] [PATCH v3 07/16] hw/i2c/omap_i2c: Use qemu_log_mask(UNIMP) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-trivial] [PATCH v3 09/16] hw/arm/omap: Use qemu_log_mask(GUEST_ERROR) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-trivial] [PATCH v3 10/16] hw/arm/stellaris: Use qemu_log_mask(UNIMP) instead of fprintf, Philippe Mathieu-Daudé, 2018/06/24
- [Qemu-trivial] [PATCH v3 11/16] hw/net/stellaris_enet: Fix a typo, Philippe Mathieu-Daudé, 2018/06/24