qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v5 12/46] hw/tpm: Use the IEC binary prefix de


From: Igor Mammedov
Subject: Re: [Qemu-trivial] [PATCH v5 12/46] hw/tpm: Use the IEC binary prefix definitions
Date: Wed, 27 Jun 2018 13:24:29 +0200

On Mon, 25 Jun 2018 09:42:04 -0300
Philippe Mathieu-Daudé <address@hidden> wrote:

> It eases code review, unit is explicit.
> 
> Patch generated using:
> 
>   $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/
> 
> and modified manually.
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Reviewed-by: Marc-André Lureau <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>

> ---
>  include/hw/acpi/tpm.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/hw/acpi/tpm.h b/include/hw/acpi/tpm.h
> index 46ac4dc581..3580ffd50c 100644
> --- a/include/hw/acpi/tpm.h
> +++ b/include/hw/acpi/tpm.h
> @@ -16,6 +16,7 @@
>  #ifndef HW_ACPI_TPM_H
>  #define HW_ACPI_TPM_H
>  
> +#include "qemu/units.h"
>  #include "hw/registerfields.h"
>  
>  #define TPM_TIS_ADDR_BASE           0xFED40000
> @@ -176,7 +177,7 @@ REG32(CRB_DATA_BUFFER, 0x80)
>  #define TPM_CRB_ADDR_CTRL           (TPM_CRB_ADDR_BASE + A_CRB_CTRL_REQ)
>  #define TPM_CRB_R_MAX               R_CRB_DATA_BUFFER
>  
> -#define TPM_LOG_AREA_MINIMUM_SIZE   (64 * 1024)
> +#define TPM_LOG_AREA_MINIMUM_SIZE   (64 * KiB)
>  
>  #define TPM_TCPA_ACPI_CLASS_CLIENT  0
>  #define TPM_TCPA_ACPI_CLASS_SERVER  1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]