Re: [Qemu-trivial] [Qemu-devel] [PATCH v5 01/46] include: Add IEC binary prefixes in "qemu/units.h"

[Igor Mammedov]

On Mon, 25 Jun 2018 09:41:53 -0300
Philippe Mathieu-Daudé <address@hidden> wrote:

> Loosely based on 076b35b5a56.
> 
> Suggested-by: Stefan Weil <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  include/qemu/units.h | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>  create mode 100644 include/qemu/units.h
> 
> diff --git a/include/qemu/units.h b/include/qemu/units.h
> new file mode 100644
> index 0000000000..692db3fbb2
> --- /dev/null
> +++ b/include/qemu/units.h
> @@ -0,0 +1,20 @@
> +/*
> + * IEC binary prefixes definitions
> + *
> + * Copyright (C) 2015 Nikunj A Dadhania, IBM Corporation
> + * Copyright (C) 2018 Philippe Mathieu-Daudé <address@hidden>
> + *
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + */
> +
> +#ifndef QEMU_UNITS_H
> +#define QEMU_UNITS_H
> +
> +#define KiB     (INT64_C(1) << 10)
> +#define MiB     (INT64_C(1) << 20)
> +#define GiB     (INT64_C(1) << 30)
> +#define TiB     (INT64_C(1) << 40)
> +#define PiB     (INT64_C(1) << 50)
> +#define EiB     (INT64_C(1) << 60)
Shouldn't above use UINT64_C()

> +
> +#endif