[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [qemu-s390x] [PATCH 5/6] target/s390x: fix PACK readi

From: Thomas Huth
Subject: Re: [Qemu-trivial] [qemu-s390x] [PATCH 5/6] target/s390x: fix PACK reading 1 byte less and writing 1 byte more
Date: Tue, 7 Aug 2018 11:42:54 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 08/05/2018 08:28 PM, Pavel Zbitskiy wrote:
> PACK fails on the test from the Principles of Operation: F1F2F3F4
> becomes 0000234C instead of 0001234C due to an off-by-one error.
> Furthermore, it overwrites one extra byte to the left of F1.

 Hi Pavel,

thanks for fixing these bugs in the s390x instructions! If you've got
some more spare minutes, could you maybe also add regression tests for
these (user space) instruction to the tests/tcg/s390x folder? ... we
really need some tests there ...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]