qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] Drop the "qemu:" prefix from err


From: Mao Zhongyi
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Drop the "qemu:" prefix from error_report()
Date: Thu, 20 Sep 2018 21:18:53 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0



On 9/20/18 1:39 PM, Peter Maydell wrote:
     if (flags & 0x00000004) { /* MULTIBOOT_HEADER_HAS_VBE */
-        error_report("qemu: multiboot knows VBE. we don't.");
+        error_report("multiboot knows VBE. we don't.");
Since this one is intended to be a user-facing error message
rather than just a debug note, it could also be reasonably expanded
to be a bit more user friendly, eg:
 "This multiboot image uses VBE, which QEMU does not support."

But that's a different patch.

OK, I will commit a separate patch for it.

Thanks,
Mao

reply via email to

[Prev in Thread] Current Thread [Next in Thread]