[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 06/10] thunk.c: clean up commented out definit
|
From: |
Laurent Vivier |
|
Subject: |
Re: [Qemu-trivial] [PATCH 06/10] thunk.c: clean up commented out definition |
|
Date: |
Thu, 4 Oct 2018 18:24:24 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
Le 04/10/2018 à 18:18, Cleber Rosa a écrit :
> Signed-off-by: Cleber Rosa <address@hidden>
> ---
> thunk.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/thunk.c b/thunk.c
> index d5d8645cd4..e351ae53af 100644
> --- a/thunk.c
> +++ b/thunk.c
> @@ -21,8 +21,6 @@
> #include "qemu.h"
> #include "exec/user/thunk.h"
>
> -//#define DEBUG
> -
Generally we use that to enable easily existing debug traces.
In this case, if you remove the "#define" I think you should also
replace the "#ifdef DEBUG"s by some trace_XXXX() functions.
Thanks,
Laurent
[Qemu-trivial] [PATCH 06/10] thunk.c: clean up commented out definition, Cleber Rosa, 2018/10/04
- Re: [Qemu-trivial] [PATCH 06/10] thunk.c: clean up commented out definition,
Laurent Vivier <=
[Qemu-trivial] [PATCH 05/10] docs/devel/testing.rst: add missing newlines after code block, Cleber Rosa, 2018/10/04
[Qemu-trivial] [PATCH 07/10] scripts/decodetree.py: remove unused imports, Cleber Rosa, 2018/10/04
[Qemu-trivial] [PATCH 08/10] scripts/decodetree.py: fix reference to attributes, Cleber Rosa, 2018/10/04