[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH 01/10] qemu-img.c: comment typo f
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH 01/10] qemu-img.c: comment typo fix |
Date: |
Fri, 5 Oct 2018 15:31:49 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 04/10/2018 18:53, Cleber Rosa wrote:> On 10/4/18 12:48 PM, Eric Blake
wrote:
>> On 10/4/18 11:18 AM, Cleber Rosa wrote:
>>> A trivial comment typo fix.
>>>
>>> Signed-off-by: Cleber Rosa <address@hidden>
>>> ---
>>> qemu-img.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/qemu-img.c b/qemu-img.c
>>> index b12f4cd19b..a96b76c187 100644
>>> --- a/qemu-img.c
>>> +++ b/qemu-img.c
>>> @@ -1085,7 +1085,7 @@ static int64_t find_nonzero(const uint8_t *buf,
>>> int64_t n)
>>> }
>>> /*
>>> - * Returns true iff the first sector pointed to by 'buf' contains at
>>> least
>>> + * Returns true if the first sector pointed to by 'buf' contains at
>>> least
>>
>> NACK. You're not the first person to propose this change. However,
>> "iff" is an English word (albeit archaic) which is shorthand for "if and
>> only if", which has a distinct logical meaning separate from the weaker
>> "if". Spelling it out in longhand instead of calling it a typo is
>> probably acceptable, though.
>>
>
> Wow, thanks for the explanation. I agree that spelling it out is a good
> option, as it'll probably prevent other people from falling into the
> same "language trap" as I did.
https://lists.gnu.org/archive/html/qemu-devel/2011-06/msg01269.html
https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg04200.html
;)