[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-block] [PATCH 05/10] docs/devel/testing.rst: ad
From: |
John Snow |
Subject: |
Re: [Qemu-trivial] [Qemu-block] [PATCH 05/10] docs/devel/testing.rst: add missing newlines after code block |
Date: |
Mon, 8 Oct 2018 15:49:34 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 10/04/2018 12:18 PM, Cleber Rosa wrote:
> The line immediate following a ".. code::" block is considered
> to contains arguments to the "code directive". The lack of a
> new line gives me during at parse time:
>
> testing.rst:63: (ERROR/3) Error in "code" directive:
> maximum 1 argument(s) allowed, 3 supplied.
>
> .. code::
> make check-unit V=1
>
> testing.rst:120: (ERROR/3) Error in "code" directive:
> maximum 1 argument(s) allowed, 3 supplied.
>
> .. code::
> make check-qtest V=1
>
pandoc doesn't complain, but rst.ninjs.org does. What tool did you use
to find these? we should formalize a formatting checker for rst files.
Actually, we should formalize building our RST docs at all...
--js
> Let's add the missing newlines, both for consistency and to
> avoid the parsing errors.
>
> Signed-off-by: Cleber Rosa <address@hidden>
Reviewed-by: John Snow <address@hidden>
- Re: [Qemu-trivial] [Qemu-devel] [PATCH 03/10] qemu-iotests: make 218 executable, (continued)
Re: [Qemu-trivial] [PATCH 03/10] qemu-iotests: make 218 executable, Laurent Vivier, 2018/10/25
[Qemu-trivial] [PATCH 06/10] thunk.c: clean up commented out definition, Cleber Rosa, 2018/10/04
[Qemu-trivial] [PATCH 05/10] docs/devel/testing.rst: add missing newlines after code block, Cleber Rosa, 2018/10/04
[Qemu-trivial] [PATCH 07/10] scripts/decodetree.py: remove unused imports, Cleber Rosa, 2018/10/04
[Qemu-trivial] [PATCH 08/10] scripts/decodetree.py: fix reference to attributes, Cleber Rosa, 2018/10/04
[Qemu-trivial] [PATCH 09/10] scripts/qemu.py: use a more consistent docstring style, Cleber Rosa, 2018/10/04