qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] memory.h: fix types in comments


From: Laurent Vivier
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] memory.h: fix types in comments
Date: Thu, 25 Oct 2018 14:54:08 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 09/10/2018 11:37, Li Qiang wrote:
> 
> 
> Peter Maydell <address@hidden
> <mailto:address@hidden>> 于2018年10月9日周二 下午6:26写道:
> 
>     On 9 October 2018 at 11:21, Li Qiang <address@hidden
>     <mailto:address@hidden>> wrote:
>     > Signed-off-by: Li Qiang <address@hidden <mailto:address@hidden>>
>     > ---
>     >  include/exec/memory.h | 6 +++---
>     >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
>     Thanks. Contents of patch
>     Reviewed-by: Peter Maydell <address@hidden
>     <mailto:address@hidden>>
> 
>     but the commit message should say "fix typos", not "fix types"
>     (a 'typo' is a typing mistake; a 'type' is something like "uint32_t".)
> 
> 
> Indeed, hope the maintainer can fix this typo when queuing this patch, :)
> 
> In additon, Cc:address@hidden <mailto:address@hidden>
>  

Applied to qemu-trivial branch

Thanks,
Laurent




reply via email to

[Prev in Thread] Current Thread [Next in Thread]