[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH 1/1] virtio-blk: fix comment for virtio_blk_rw
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-trivial] [PATCH 1/1] virtio-blk: fix comment for virtio_blk_rw_complete as nalloc is initially -1 |
Date: |
Tue, 6 Nov 2018 08:58:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 06/11/2018 05:52, Dongli Zhang wrote:
> The initial value of nalloc is -1, but not 1.
>
> Signed-off-by: Dongli Zhang <address@hidden>
> ---
> This is based on git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git
> tags/for_upstream
>
> hw/block/virtio-blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> index 83cf5c0..30999c3 100644
> --- a/hw/block/virtio-blk.c
> +++ b/hw/block/virtio-blk.c
> @@ -96,7 +96,7 @@ static void virtio_blk_rw_complete(void *opaque, int ret)
> trace_virtio_blk_rw_complete(vdev, req, ret);
>
> if (req->qiov.nalloc != -1) {
> - /* If nalloc is != 1 req->qiov is a local copy of the original
> + /* If nalloc is != -1 req->qiov is a local copy of the original
> * external iovec. It was allocated in submit_requests to be
> * able to merge requests. */
> qemu_iovec_destroy(&req->qiov);
>
Reviewed-by: Laurent Vivier <address@hidden>