Re: [Qemu-trivial] [Qemu-devel] [PATCH] target: hax: replace g_malloc with g_malloc0

[Philippe Mathieu-Daudé]

On 15/11/18 7:05, Li Qiang wrote:
> And also the g_malloc doesn't need check return value,
> remove it.
>
> Cc: address@hidden
>
> Signed-off-by: Li Qiang <address@hidden>
> ---
>   target/i386/hax-all.c | 15 +++------------
>   1 file changed, 3 insertions(+), 12 deletions(-)
>
> diff --git a/target/i386/hax-all.c b/target/i386/hax-all.c
> index d2e512856b..a460c605af 100644
> --- a/target/i386/hax-all.c
> +++ b/target/i386/hax-all.c
> @@ -154,13 +154,7 @@ int hax_vcpu_create(int id)
>           return 0;
>       }
>   
> -    vcpu = g_malloc(sizeof(struct hax_vcpu_state));
> -    if (!vcpu) {
> -        fprintf(stderr, "Failed to alloc vcpu state\n");
> -        return -ENOMEM;
> -    }
> -
> -    memset(vcpu, 0, sizeof(struct hax_vcpu_state));
> +    vcpu = g_malloc0(sizeof(struct hax_vcpu_state));

Can you use the g_new form?

       vcpu = g_new0(struct hax_vcpu_state, 1);

>   
>       ret = hax_host_create_vcpu(hax_global.vm->fd, id);
>       if (ret) {
> @@ -250,11 +244,8 @@ struct hax_vm *hax_vm_create(struct hax_state *hax)
>           return hax->vm;
>       }
>   
> -    vm = g_malloc(sizeof(struct hax_vm));
> -    if (!vm) {
> -        return NULL;
> -    }
> -    memset(vm, 0, sizeof(struct hax_vm));
> +    vm = g_malloc0(sizeof(struct hax_vm));

Ditto.

> +
>       ret = hax_host_create_vm(hax, &vm_id);
>       if (ret) {
>           fprintf(stderr, "Failed to create vm %x\n", ret);

This patch as it or using g_new0:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>