qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v3] qapi: Reduce Makefile boilerplate


From: Laurent Vivier
Subject: Re: [Qemu-trivial] [PATCH v3] qapi: Reduce Makefile boilerplate
Date: Thu, 22 Nov 2018 13:20:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 16/11/2018 21:00, Eric Blake wrote:
> Adding a new qapi module had some rather tedious repetition to
> wire it into Makefile, Makefile.objs, and .gitignore (for example,
> see commit bf42508f and its followup b61acdec). For make, add some
> indirection by taking advantage of GNU Make string processing to
> expand a list of module names into all the required artifacts, so
> that future additions of a new module need only touch the list of
> module names.  And for gitignore, use globs to cover all generated
> file names.
> 
> The list has to live in Makefile.objs, due to the way that
> our unnest-vars macro slirps in that file without remembering
> any definition of $(QAPI_MODULES) from Makefile.
> 
> Signed-off-by: Eric Blake <address@hidden>
> 
> ---
> v3: also tweak .gitignore [Dan]
> v2: also condense Makefile.objs, prefer $(FOO:%=a%b) over
> $(patsubst %,a%b,$(FOO))
> ---
>  Makefile      | 192 ++++++--------------------------------------------
>  Makefile.objs |  75 ++------------------
>  .gitignore    |  72 ++-----------------
>  3 files changed, 34 insertions(+), 305 deletions(-)

Applied to qemu-trivial branch.

Thanks,
Laurent



reply via email to

[Prev in Thread] Current Thread [Next in Thread]