qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] scsi: Address spurious clang warning


From: Peter Maydell
Subject: Re: [Qemu-trivial] [PATCH] scsi: Address spurious clang warning
Date: Wed, 28 Nov 2018 00:37:42 +0000

On Tue, 27 Nov 2018 at 18:49, John Snow <address@hidden> wrote:
>
> Some versions of Clang prior to 6.0 (and some builds of clang after,
> such as 6.0.1-2.fc28) fail to recognize { 0 } as a valid initializer
> for a struct with subobjects when -Wmissing-braces is enabled.
>
> https://bugs.llvm.org/show_bug.cgi?id=21689 and
> https://reviews.llvm.org/rL314499 suggests this should be fixed in 6.0,
> but it might not be the case for older versions or downstream versions.
>
> For now, follow the precedent of ebf2a499 and replace the standard { 0 }
> with the accepted { } to silence this warning and allow the build to
> work under clang 6.0.1-2.fc28, and builds prior to 6.0.
>
> Signed-off-by: John Snow <address@hidden>

Applied to master as a build fix for rc3, thanks.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]