[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 1/4] block/ssh: Convert from D

From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 1/4] block/ssh: Convert from DPRINTF() macro to trace events
Date: Thu, 13 Dec 2018 10:34:12 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/13/18 10:27 AM, Laurent Vivier wrote:
Signed-off-by: Laurent Vivier <address@hidden>
Reviewed-by: Richard W.M. Jones <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

     v2: use %zu with size_t
         change an uint64_t to int64_t to match % PRIi64

Why PRIi64? It's identical to PRId64, but the sources show a strong preference for %d over %i:

$ git grep PRIi[0-9] | wc
     25     172    1885
$ git grep PRId[0-9] | wc
    415    3991   40345

$ git grep '%i' | wc
    231    1664   18269
$ git grep '%d' | wc
   5492   46211  498225

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]