Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] checkpatch: Flag suspicious attribution lines

[Cornelia Huck]

On Tue, 5 Feb 2019 00:29:14 +0100
Philippe Mathieu-Daudé <address@hidden> wrote:

> On 2/4/19 11:55 PM, Eric Blake wrote:
> > Flag commit attribution tags that are unusual (often because they
> > were a typo), but only as a warning (because sometimes a humorous
> > or otherwise useful tag is intentionally supplied).
> > 
> > This picks the 6-most popular tags, each with 700 or more uses (well,
> > S-o-b was already checked for case-sensitivity and typos, leaving
> > only 5 new tags being checked), as determined by:
> > $ git log | sed -n 's/^ *\([A-Za-z-]*-by:\).*/\1/p' | \
> >   sort | uniq -c | sort -k1,1n | tail
> > 
> > Most of the rejected lines were obvious typos (among others, we've
> > had 4 cases of someone being burnt, based on Singed-off-by; and 2
> > cases of list-reading via an e-reader, based on eviewed-by; there
> > are also lines forgetting a space after the ':') or otherwise
> > tongue-in-check (3 Approximately-suggested-by). A few lines not
> > whitelisted here may be legitimate, but as they are orders of
> > magnitude rarer, it is therefore not worth worrying about
> > (7 Requested-by, 3 Co-authored-by, 1 Inspired-by, etc.).  

Hm, wasn't Co-authored-by: actually intended to cover the cases where
someone else did write significant parts of the patch? (I cannot point
to the source without searching, though...)

> 
> 'Inspired-by' is kinda Zen :) And is from Peter!

I also like that one :)