qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi


From: Wei Yang
Subject: Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi
Date: Thu, 14 Feb 2019 16:39:55 +0800
User-agent: Mutt/1.10.1 (2018-07-13)

On Thu, Feb 14, 2019 at 09:23:39AM +0100, Laurent Vivier wrote:
>On 14/02/2019 09:18, Wei Yang wrote:
>> On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote:
>>> On 14/02/2019 08:57, Laurent Vivier wrote:
>>>> On 14/02/2019 01:03, Wei Yang wrote:
>>>>> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote:
>>>>>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote:
>>>>>>> Hi Laurent,
>>>>>>>
>>>>>>> On 2/13/19 9:49 AM, Laurent Vivier wrote:
>>>>>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>>>>>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>>>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>>>>>>>> There are several functions/variable which are not used anymore.
>>>>>>>>>>>
>>>>>>>>>>> This serials just remove those without functional change.
>>>>>>>>>>>
>>>>>>>>>>> v3: add ack and repost in a new thread
>>>>>>>>>>> v2: change commit log from "is now used in no place" to "in not 
>>>>>>>>>>> used anymore"
>>>>>>>>>>
>>>>>>>>>> Michael,
>>>>>>>>>>
>>>>>>>>>> Looks this serials is not merged yet.
>>>>>>>>>>
>>>>>>>>>> Is there any problem I need to fix?
>>>>>>>>>
>>>>>>>>> Yes pls repost with fixed reviewed-by tags.
>>>>>>>>
>>>>>>>> Or I can take the series through the trivial branch and update manually
>>>>>>>> Philippe's lastname?
>>>>>>>
>>>>>>> I appreciate the help with manual update, however Wei is not the only
>>>>>>> one having this problem (other developpers has non-ASCII in their name,
>>>>>>> and use such tags).
>>>>>>> I'd rather prefer we find a proper configuration setup to help the
>>>>>>> community.
>>>>>>
>>>>>> I'm wondering if it can be a problem with cut'n'paste rather than with
>>>>>> git-sendemail.
>>>>>>
>>>>>> I think the following tags should cover Latin and Chinese characters:
>>>>>>
>>>>>> Content-Type: text/plain; charset=UTF-8
>>>>>> Content-Transfer-Encoding: 8bit
>>>>>>
>>>>>
>>>>> Looks not work.
>>>>>
>>>>> I have tried this and also with 
>>>>>
>>>>> Content-Language: en-US
>>>>
>>>> Could  you send me a gzipped version of the 0001-XXX.patch in attachment
>>>> so I could see the real content before git-send-email?
>>>
>>> OK, I've got it.
>>>
>>> What I see is it is already corrupted, thus the problem is not with
>>> git-send-email.
>>>
>>> So either it is corrupted by git-format-patch (which is very unlikely,
>>> we could see that if you push it to a public git repo) or it has been
>>> corrupted when you have added it to the commit message.
>>>
>> 
>> Hmm... maybe you are right.
>> 
>> But I found confused how to fix this.
>> 
>> When I use git commit --amend to fix it, the character looks good in my
>> editor. I use vim as my git editor.
>> 
>> But when I use git show, it display an unknown character.
>> 
>> And if I use git format-patch, the patch file looks good in my vim editor. 
>> But
>> corrupted if I use another editor.
>> 
>> Do you have any idea on this?
>
>What is the result of command "locale" in your terminal?
>How do you copy the characters to vim?
>

My locale output:

    $ locale
    LANG=en_US.UTF-8
    LANGUAGE=
    LC_CTYPE="en_US.UTF-8"
    LC_NUMERIC=zh_CN.UTF-8
    LC_TIME=zh_CN.UTF-8
    LC_COLLATE="en_US.UTF-8"
    LC_MONETARY=zh_CN.UTF-8
    LC_MESSAGES="en_US.UTF-8"
    LC_PAPER=zh_CN.UTF-8
    LC_NAME=zh_CN.UTF-8
    LC_ADDRESS=zh_CN.UTF-8
    LC_TELEPHONE=zh_CN.UTF-8
    LC_MEASUREMENT=zh_CN.UTF-8
    LC_IDENTIFICATION=zh_CN.UTF-8
    LC_ALL=

I copy&paste the character from mutt to vim. Let me see if it would work if I
save the character from mutt mail itself.

>Thanks,
>Laurent

-- 
Wei Yang
Help you, Help me



reply via email to

[Prev in Thread] Current Thread [Next in Thread]