Re: [Qemu-trivial] [PATCH v3 0/3] Trivial cleanup in hw/acpi

[Laurent Vivier]

On 14/02/2019 09:51, Wei Yang wrote:
> On Thu, Feb 14, 2019 at 09:23:39AM +0100, Laurent Vivier wrote:
>> On 14/02/2019 09:18, Wei Yang wrote:
>>> On Thu, Feb 14, 2019 at 09:10:14AM +0100, Laurent Vivier wrote:
>>>> On 14/02/2019 08:57, Laurent Vivier wrote:
>>>>> On 14/02/2019 01:03, Wei Yang wrote:
>>>>>> On Wed, Feb 13, 2019 at 02:45:01PM +0100, Laurent Vivier wrote:
>>>>>>> On 13/02/2019 09:56, Philippe Mathieu-Daudé wrote:
>>>>>>>> Hi Laurent,
>>>>>>>>
>>>>>>>> On 2/13/19 9:49 AM, Laurent Vivier wrote:
>>>>>>>>> On 12/02/2019 06:34, Michael S. Tsirkin wrote:
>>>>>>>>>> On Tue, Feb 12, 2019 at 01:22:24PM +0800, Wei Yang wrote:
>>>>>>>>>>> On Wed, Jan 30, 2019 at 08:06:50AM +0800, Wei Yang wrote:
>>>>>>>>>>>> There are several functions/variable which are not used anymore.
>>>>>>>>>>>>
>>>>>>>>>>>> This serials just remove those without functional change.
>>>>>>>>>>>>
>>>>>>>>>>>> v3: add ack and repost in a new thread
>>>>>>>>>>>> v2: change commit log from "is now used in no place" to "in not 
>>>>>>>>>>>> used anymore"
>>>>>>>>>>>
>>>>>>>>>>> Michael,
>>>>>>>>>>>
>>>>>>>>>>> Looks this serials is not merged yet.
>>>>>>>>>>>
>>>>>>>>>>> Is there any problem I need to fix?
>>>>>>>>>>
>>>>>>>>>> Yes pls repost with fixed reviewed-by tags.
>>>>>>>>>
>>>>>>>>> Or I can take the series through the trivial branch and update 
>>>>>>>>> manually
>>>>>>>>> Philippe's lastname?
>>>>>>>>
>>>>>>>> I appreciate the help with manual update, however Wei is not the only
>>>>>>>> one having this problem (other developpers has non-ASCII in their name,
>>>>>>>> and use such tags).
>>>>>>>> I'd rather prefer we find a proper configuration setup to help the
>>>>>>>> community.
>>>>>>>
>>>>>>> I'm wondering if it can be a problem with cut'n'paste rather than with
>>>>>>> git-sendemail.
>>>>>>>
>>>>>>> I think the following tags should cover Latin and Chinese characters:
>>>>>>>
>>>>>>> Content-Type: text/plain; charset=UTF-8
>>>>>>> Content-Transfer-Encoding: 8bit
>>>>>>>
>>>>>>
>>>>>> Looks not work.
>>>>>>
>>>>>> I have tried this and also with 
>>>>>>
>>>>>> Content-Language: en-US
>>>>>
>>>>> Could  you send me a gzipped version of the 0001-XXX.patch in attachment
>>>>> so I could see the real content before git-send-email?
>>>>
>>>> OK, I've got it.
>>>>
>>>> What I see is it is already corrupted, thus the problem is not with
>>>> git-send-email.
>>>>
>>>> So either it is corrupted by git-format-patch (which is very unlikely,
>>>> we could see that if you push it to a public git repo) or it has been
>>>> corrupted when you have added it to the commit message.
>>>>
>>>
>>> Hmm... maybe you are right.
>>>
>>> But I found confused how to fix this.
>>>
>>> When I use git commit --amend to fix it, the character looks good in my
>>> editor. I use vim as my git editor.
>>>
>>> But when I use git show, it display an unknown character.
>>>
>>> And if I use git format-patch, the patch file looks good in my vim editor. 
>>> But
>>> corrupted if I use another editor.
>>>
>>> Do you have any idea on this?
>>
>> What is the result of command "locale" in your terminal?
>> How do you copy the characters to vim?
>>
> 
> Hi, Laurent
> 
> I tried to copied the character directly from Philippe's mail.
> 
> This time looks good from my mutt client. Hope it works for you.

Yes, it's fine.

I let Michael to take the series for the pull request.

Thanks,
Laurent