qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] CODING_STYLE: indent example


From: Eric Blake
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/2] CODING_STYLE: indent example code as all others
Date: Tue, 19 Feb 2019 11:56:43 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0

On 2/19/19 11:38 AM, Philippe Mathieu-Daudé wrote:

>> +    if (a == 1) {
>> +        /* Reads like: "If a equals 1" */
> 
> I guess you found a bug in the documentation :)
> 
> Since 8c06fbdf36bf4d the style asked is:
> 
>     We now require Linux-kernel-style multiline comments:
>         /*
>          * line one
>          * line two
>          */
> 
>> +        do_something();

We only require winged multiline comments when the comment is actually
multiline.  In this case, the comment is a one-liner, and is just fine
as written.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]