Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 0/2] util/readline: errors clean-ups

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v2 0/2] util/readline: errors clean-ups
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
2e75b209af util: readline: replace tab indent by four spaces to fix checkpatch 
errors
d797524276 util/readline: add a space to fix errors by checkpatch tool

=== OUTPUT BEGIN ===
1/2 Checking commit d79752427670 (util/readline: add a space to fix errors by 
checkpatch tool)
ERROR: braces {} are necessary for all arms of this statement
#31: FILE: util/readline.c:57:
+            for (i = 0; i < len; i++)
[...]

total: 1 errors, 0 warnings, 109 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit 2e75b209af4f (util: readline: replace tab indent by four 
spaces to fix checkpatch errors)
ERROR: braces {} are necessary for all arms of this statement
#32: FILE: util/readline.c:186:
+            if (rs->history[idx] == NULL)
[...]

ERROR: braces {} are necessary for all arms of this statement
#101: FILE: util/readline.c:233:
+        if (hist_entry == NULL)
[...]

ERROR: braces {} are necessary for all arms of this statement
#111: FILE: util/readline.c:243:
+                if (rs->history[idx] == NULL)
[...]

total: 3 errors, 0 warnings, 145 lines checked

Patch 2/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden