[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/char/escc: Lower irq when tra
|
From: |
Stephen Checkoway |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/char/escc: Lower irq when transmit buffer is filled |
|
Date: |
Tue, 16 Apr 2019 20:55:33 -0400 |
> On Apr 10, 2019, at 16:01, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> So your description and patch makes sens.
> What worries me is the controller could have other pending IRQs to
> deliver and you are clearing them. Shouldn't we only clear the
> INTR_TXINT bit, and call escc_update_irq() which should lower the IRQ if
> no bits are pending?
>
> Maybe as:
>
> s->wregs[W_INTR] &= ~INTR_TXINT;
> escc_update_irq(s);
I just sent a v2 patch (but it looks like I failed to include Philippe, sorry
about that!)
I used
s->txint = 0;
escc_update_irq(s);
which appears to do the right thing in my tests.
Thank you,
Steve
--
Stephen Checkoway