Re: [Qemu-trivial] [PATCH] Makefile: Let the 'clean' rule remove qemu-ga.exe on Windows hosts

[Stefan Weil]

On 27.04.19 18:13, Philippe Mathieu-Daudé wrote:
> Commit 48ff7a625b36 added the QEMU Guest Agent tool with the
> optional ".exe" suffix for Windows hosts, but forgot to use
> this suffix in the 'clean' rule. Calling this rule let a dangling
> executable in the build directory.
> Correct this by using the proper optional suffix.
> 
> Fixes: 48ff7a625b36
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 626a04d305c..07bfa26536a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -639,7 +639,7 @@ clean:
>               ! -path ./roms/edk2/BaseTools/Source/Python/UPT/Dll/sqlite3.dll 
> \
>               -exec rm {} +
>       rm -f $(edk2-decompressed)
> -     rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga TAGS cscope.* 
> *.pod *~ */*~
> +     rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga$(EXESUF) TAGS 
> cscope.* *.pod *~ */*~
>       rm -f fsdev/*.pod scsi/*.pod
>       rm -f qemu-img-cmds.h
>       rm -f ui/shader/*-vert.h ui/shader/*-frag.h
> 

Reviewed-by: Stefan Weil <address@hidden>

Thank you!

Stefan