[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 2/5] hw/usb/hcd-xhci: Fix GCC
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-trivial] [Qemu-devel] [PATCH v2 2/5] hw/usb/hcd-xhci: Fix GCC 9 build warning |
|
Date: |
Wed, 1 May 2019 17:21:21 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/1/19 4:12 PM, Richard Henderson wrote:
> On 4/30/19 4:28 PM, Alistair Francis wrote:
>> for (i = 0; i < usbports; i++) {
>> + g_assert(i < MAX(MAXPORTS_2, MAXPORTS_3));
>
> I would hope that it works to move this out of the loop:
>
> g_assert(usbports <= MAX(MAXPORTS_2, MAXPORTS_3));
With Richard suggestion:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>